remove deprecate warnings when using openssl v3 #1826
Conversation
MarcelJordense
force-pushed
the
update_security_to_opensslv3
branch
from
c8edcd4
to
d9eba58
Compare
MarcelJordense
force-pushed
the
update_security_to_opensslv3
branch
from
d9eba58
to
13e6185
Compare
There was a problem hiding this comment.
I think I should've merged this a long time ago already ... or at least reviewed it properly because I do have two questions/remarks. They're totally trivial details, to be honest.
Now that the CI is working again on Windows on master — the problems were caused by a combination of CMake, OpenSSL 3.2.1 and Chocolatey — it would be also be nice to see those builds green with this PR.
Perhaps you would be willing to consider my two comments, possibly update the code and rebase it once more to master?
| @@ -38,7 +38,7 @@ | |||
| #include <WinSock2.h> | |||
| #endif | |||
|
|
|||
| #define OPENSSL_API_COMPAT 10101 | |||
| #define OPENSSL_API_COMPAT 30000 | |||
There was a problem hiding this comment.
I guess this should be defined to 10101 when using OpenSSL < 3.0.0, but I checked and OpenSSL 1.1.1 doesn't care if it is set too high. Making it conditional on the OpenSSL version number seems overkill, but a comment to this effect might be useful.
MarcelJordense
force-pushed
the
update_security_to_opensslv3
branch
from
13e6185
to
c014f8e
Compare
…sl v3 Signed-off-by: Marcel Jordense <marcel@zettascale.tech>
Signed-off-by: Marcel Jordense <marcel@zettascale.tech>
MarcelJordense
force-pushed
the
update_security_to_opensslv3
branch
from
c014f8e
to
37baf0c
Compare
Some of the Openssl v1.1.1 function used by the authentication security plugin have become deprecated in Openssl v3. These functions have been replaced by the corresponding function provided by Openssl v3.