Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Automate configuration of Import from Git factory creation feature #23086

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

From Openshift DevSpaces 3.14 we can configure factory creation on Dashboard by Import from Git feature(select branch name, path to devfile.yaml, change remote name and url). This PR add new test that check factory with specific branh.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Automate configuration of Import from Git feature

How to test this PR?

  • set TS_SELENIUM_FACTORY_GIT_REPO_URL and TS_SELENIUM_FACTORY_GIT_REPO_BRANCH env with repo url and expected branch name of this repo
  • start FactoryWithGitRepoOptions test

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. area/qe labels Aug 14, 2024
@SkorikSergey SkorikSergey self-assigned this Aug 14, 2024
@SkorikSergey SkorikSergey marked this pull request as ready for review August 14, 2024 09:54
@SkorikSergey SkorikSergey changed the title [Test] Automate configuration of Import from Git feature [Test] Automate configuration of Import from Git factory creation feature Aug 14, 2024
@dmytro-ndp
Copy link
Contributor

PR looks commonly good.

But I would propose to extend an ability to create factory from specific branch to existed factory tests Factory.spec.ts, FactoryWithGitRepoOptions.spec.ts, NoSetupRepoFactory.spec.ts, RefusedOAuthFactory.spec.ts.
It will allow us to cover more test cases, and continue using existed Dev Spaces test pipelines as it without further modifications.

@SkorikSergey
Copy link
Contributor Author

SkorikSergey commented Aug 14, 2024

PR looks commonly good.

But I would propose to extend an ability to create factory from specific branch to existed factory tests Factory.spec.ts, FactoryWithGitRepoOptions.spec.ts, NoSetupRepoFactory.spec.ts, RefusedOAuthFactory.spec.ts. It will allow us to cover more test cases, and continue using existed Dev Spaces test pipelines as it without further modifications.

Thanks. Good idea about factories tests. I would like to have this test also, planning to check other parts of git config options(like setting path to devfile.yaml)

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkorikSergey SkorikSergey merged commit 245bb11 into main Aug 14, 2024
5 checks passed
@SkorikSergey SkorikSergey deleted the gitconfig branch August 14, 2024 11:21
@SkorikSergey SkorikSergey removed the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants