Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto save call Updating file loader #6027

Closed
ghost opened this issue Aug 17, 2017 · 3 comments
Closed

Auto save call Updating file loader #6027

ghost opened this issue Aug 17, 2017 · 3 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone

Comments

@ghost
Copy link

ghost commented Aug 17, 2017

On fast connections and local Che this is barely visible. However, if Che is a remote one, each time auto save happens, Updating file loader shows up. Then, Getting projects.

It can be reproduced by using throttling in browser dev console on a local Che.

These loaders aren't necessary at all.

@ghost ghost added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/ide labels Aug 17, 2017
@slemeur slemeur removed the severity/P1 Has a major impact to usage or development of the system. label Aug 17, 2017
@riuvshin riuvshin added this to the 5.17.0 milestone Aug 17, 2017
@slemeur slemeur added the severity/P1 Has a major impact to usage or development of the system. label Aug 17, 2017
@slemeur
Copy link
Contributor

slemeur commented Aug 17, 2017

The problem here is that when the autosave happens, if the user is typing while that event is fired, then the changes are getting lost.

@slemeur slemeur added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed severity/P1 Has a major impact to usage or development of the system. labels Aug 17, 2017
@RomanNikitenko RomanNikitenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 17, 2017
@vparfonov vparfonov removed the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 17, 2017
@sunix
Copy link
Contributor

sunix commented Aug 21, 2017

@slemeur to properly handle this kind of issue, we should use a OT strategy to sync content changes.

@slemeur
Copy link
Contributor

slemeur commented Aug 22, 2017

You should discuss that with @RomanNikitenko and @vparfonov.

I agree that it's something we will need at some point and we should get an epic created in order to plan work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Development

No branches or pull requests

5 participants