Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check on lint errors when run EmptyWorkspace PR check in E2E typescript test repo #23221

Open
dmytro-ndp opened this issue Oct 30, 2024 · 0 comments
Open

Check on lint errors when run EmptyWorkspace PR check in E2E typescript test repo #23221

dmytro-ndp opened this issue Oct 30, 2024 · 0 comments
Assignees
@musienko-maxim
Labels
area/qe e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Oct 30, 2024 •
edited
Loading

Is your task related to a problem? Please describe

EmptyWorkspace PR check in E2E typescript test repo doesn't catch lint errors like the following: #23215

Describe the solution you'd like

run npm run lint in https://github.com/eclipse-che/che/blob/main/.github/workflows/pr-check.yml#L96

Describe alternatives you've considered

No response

Additional context

No response
@dmytro-ndp dmytro-ndp added kind/task Internal things, technical debt, and to-do tasks to be performed. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. area/qe labels Oct 30, 2024
@dmytro-ndp dmytro-ndp changed the title Check on lint errors when run EmptyWorkspace PR check in E2E typescript tests Check on lint errors when run EmptyWorkspace PR check in E2E typescript test repo Oct 30, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 30, 2024
@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 30, 2024
@musienko-maxim musienko-maxim mentioned this issue Oct 31, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@musienko-maxim musienko-maxim

Labels
area/qe e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmytro-ndp @musienko-maxim @che-bot