Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click not working after first one. #22953

Closed
guydog28 opened this issue May 6, 2024 · 4 comments
Closed

Right click not working after first one. #22953

guydog28 opened this issue May 6, 2024 · 4 comments
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy/che-only Like 'new&noteworthy' but which do not apply to downstream (eg., plugins or devfiles) severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@guydog28
Copy link

guydog28 commented May 6, 2024

Describe the bug

With the latest che, (7.85), after right clicking on something in the workspace, and choosing something from the right click menu, right click no longer pops up the menu anymore after that without refreshing the browser window.

Che version

7.85@latest

Steps to reproduce

  1. Launch Workspace
  2. Right click a file, and select Open (doesn't really matter, click on any item in any right click context menu will do).
  3. Right click the same thing again - no context menu.
  4. Refresh browser
  5. Repeat from step 2.

Expected behavior

Context menu will appear on every right click.

Runtime

Kubernetes (vanilla)

Screenshots

No response

Installation method

OperatorHub

Environment

Amazon

Eclipse Che Logs

I see these console errorr on Workspace browser load:

 GET https://che.dev.mydomain.com/myuser/my-workspace/3100/oss-dev/static/out/vsda_bg.wasm 404 (Not Found)
loader.js:3 
 
 GET https://che.dev.mydomain.com/myuser/my-workspace/3100/oss-dev/static/out/vsda.js net::ERR_ABORTED 404 (Not Found)

ERR [Extension Host] (node:6488) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

WARN: [Extension Host] Error trying to update permissions to installed binaries: Error: ENOENT: no such file or directory, scandir '/home/user/.local/state/vs-kubernetes/tools'

ERR [Extension Host] Unable to create telemetry client: "DEVWORKSPACE_TELEMETRY_BACKEND_PORT" is not set.

This shows up a bunch of times in the browser console after the first right-click attempt:

Error: Trying to add a disposable to a DisposableStore that has already been disposed of. The added object will be leaked!
    at s.add (workbench.web.main.js:37:1529)
    at o.showHover (workbench.web.main.js:734:48235)
    at I.showHover (workbench.web.main.js:647:45670)
    at I.f (workbench.web.main.js:637:2108)
    at I.update (workbench.web.main.js:637:1894)
    at workbench.web.main.js:734:49958
    at workbench.web.main.js:149:19407

Additional context

Reverting to 7.84, stopping and starting workspace resolved the issue.

@guydog28 guydog28 added the kind/bug Outline of a bug - must adhere to the bug report template. label May 6, 2024
@RomanNikitenko RomanNikitenko added area/editor/vscode Issues related to the Code OSS editor of Che team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. labels May 7, 2024
@RomanNikitenko
Copy link
Member

RomanNikitenko commented May 7, 2024

I can reproduce the behaviour using quay.io/che-incubator/che-code:7.85.0 as editor image,
thank you for reporting the problem!

I tested it for the quay.io/che-incubator/che-code:next - the bug already fixed in upstream.
Also refreshing the page works as a workaround for 7.85, although it allows to use a context menu only once and then the bug is reproduced again...

@RomanNikitenko RomanNikitenko added the severity/P1 Has a major impact to usage or development of the system. label May 7, 2024
@guydog28
Copy link
Author

guydog28 commented May 7, 2024

@RomanNikitenko We also saw that refreshing the browser brought the right click back for one time only. My team definitely did not like refreshing all day 😂. Reverting to 7.84 was better for us.

Do we know what commit it was fixed in, and if that will be a part of 7.86?

@RomanNikitenko
Copy link
Member

RomanNikitenko commented May 7, 2024

@guydog28

  • sorry, I'm not aware what commit brought the fix
  • the fix is present in the main of the Che-Code (as I can not reproduce the bug for the next version), so yes - it will be part of the 7.86

@artaleks9 artaleks9 added the e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. label May 14, 2024
@RomanNikitenko
Copy link
Member

Release process is starting today for 7.86.
The bug is fixed for that version, closing this issue.

@ibuziuk ibuziuk added the new&noteworthy/che-only Like 'new&noteworthy' but which do not apply to downstream (eg., plugins or devfiles) label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy/che-only Like 'new&noteworthy' but which do not apply to downstream (eg., plugins or devfiles) severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants