Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a worspace failed to start due to the fact that user stopped it explicitly we should not count it as a failure from the metrics perspective #18158

Closed
6 tasks
ibuziuk opened this issue Oct 21, 2020 · 0 comments · Fixed by #18258
Assignees
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Oct 21, 2020

Describe the bug

Che version

  • 7.20.0

Steps to reproduce

  • Start a workspace
  • While workspace is in the "STARTING" state go to UD and stop it explicitly
  • See the error message - 'Failed
    Runtime start for identity 'workspace: xxx, environment: default, ownerId id' is interrupted'
  • in the logs there will be smth. like

{"@timestamp":"2020-10-21T13:24:29.677+00:00","@version":1,"message":"Failed to start Kubernetes runtime of workspace workspaceuuuxkjuse6hvvme8.","logger_name":"org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime","thread_name":"WorkspaceSharedPool-28","level":"WARN","level_value":30000,"stack_trace":"org.eclipse.che.api.workspace.server.spi.RuntimeStartInterruptedException: Runtime start for identity 'workspace: xxx, environment: default, ownerId: id' is interrupted}

  • ERROR: Prometheus failure count has been incremented

Expected behavior

  • Prometheus failure count should not be incremented since the failure is user driven and expected

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Eclipse Che Logs

{"@timestamp":"2020-10-21T13:24:29.677+00:00","@version":1,"message":"Failed to start Kubernetes runtime of workspace workspaceuuuxkjuse6hvvme8.","logger_name":"org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime","thread_name":"WorkspaceSharedPool-28","level":"WARN","level_value":30000,"stack_trace":"org.eclipse.che.api.workspace.server.spi.RuntimeStartInterruptedException: Runtime start for identity 'workspace: xxx, environment: default, ownerId: id' is interrupted}

@ibuziuk ibuziuk added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 21, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 21, 2020
@ibuziuk ibuziuk added area/che-server severity/P1 Has a major impact to usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 21, 2020
@skabashnyuk skabashnyuk added this to the 7.22 milestone Oct 29, 2020
@skabashnyuk skabashnyuk self-assigned this Oct 29, 2020
@skabashnyuk skabashnyuk linked a pull request Nov 5, 2020 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants