Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin commands are not in workspace panel #15566

Open
mingfang opened this issue Dec 23, 2019 · 11 comments
Open

plugin commands are not in workspace panel #15566

mingfang opened this issue Dec 23, 2019 · 11 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@mingfang
Copy link

Commands defined in meta.yaml of plugins, such as https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/che-incubator/theia-dev/0.0.1/meta.yaml#L24, are not listed in the workspace panel tree.

The component field is also not filled in task.json

    {
        "type": "che",
        "label": "uname",
        "command": "uname -a",
        "target": {
            "workingDir": "$(project)"
            <missing or empty component field here/>
        }
    }
@mingfang mingfang added the kind/bug Outline of a bug - must adhere to the bug report template. label Dec 23, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 23, 2019
@tolusha
Copy link
Contributor

tolusha commented Dec 24, 2019

/cc @RomanNikitenko

@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 24, 2019
@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2020
@che-bot che-bot closed this as completed Jul 27, 2020
@ericwill
Copy link
Contributor

cc @tsmaeder

@ericwill ericwill reopened this Jul 27, 2020
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2020
@tsmaeder
Copy link
Contributor

tsmaeder commented Jul 28, 2020

I'm not sure you can define commands in meta.yml. @skabashnyuk, @amisevsk who is responsible for the defining the meta.yml format?
Also: we get the workspace commands via the Che API (I think workspace.commands), so the Che server would be responsible for including any such commands. Nothing the plugins team can do here @ericwill

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jul 28, 2020

uname command was included in the Workspace API response.
Знімок екрана 2020-07-28 о 13 50 33

Знімок екрана 2020-07-28 о 13 48 09

@tsmaeder
Copy link
Contributor

The command in question has the type 'custom'. However, the code in container-service.ts#117 in che-theia filters all commands that are not of type exec.

@tsmaeder
Copy link
Contributor

@skabashnyuk what should we use for determining what is current Che API and how to use it?

@amisevsk
Copy link
Contributor

As far as I know nobody owns the plugin's meta.yaml format -- we've had various additions from various sources. It's still mostly an internal API with an underdefined spec.

The data flow for meta.yamls is

meta.yaml --> plugin broker --> ChePlugin --> Che server

but apart from doing some Theia-specific work (adding the remote runtime, etc.) the broker is basically translating from meta.yaml to ChePlugins.

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jul 29, 2020

@skabashnyuk what should we use for determining what is current Che API and how to use it?

GET /api/workspace/{wsid}
As you can see on the screenshot, commands that come from plugins located in runtime object. These commands combine commands from all plugins + devfile and available only in runtime.

@tsmaeder
Copy link
Contributor

tsmaeder commented Jul 29, 2020

@skabashnyuk I was looking for reference documentation, not examples: you can never be sure whether you have seen all the possible cases with examples.

@skabashnyuk
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

9 participants