Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic way to determine total number of rows for table-output-component #792

Open
bhufmann opened this issue Jul 19, 2022 · 0 comments
Labels
bug Something isn't working Theia UI frontend Trace Server Involve changes in the trace server itself (in the incubator source code)

Comments

@bhufmann
Copy link
Collaborator

For the events table there is an indexing loop (see trace-context-component method updateTrace()) that checks for number of events and updates the nbEvents which then triggers the function call componentDidUpdate() in table-output-component. The componentDidUpdate() sets the infiniteRowCount which then updates the vertical scrollbar. When opening the table with a segment store there is no corresponding indexing loop that updates the nbEvents and the scrollbar.

Setting the row count only when fetching the table lines works, only when the fetchTableLines call to fill the table initially returns the final total number of segments i.e. that the back-end has the value available at that time.

I think there should be a generic way to determine the table size for any virtual table data providers. The data provider API might have to be augmented for that.

Originally posted by @bhufmann in #784 (comment)

@bhufmann bhufmann added bug Something isn't working Theia UI frontend Trace Server Involve changes in the trace server itself (in the incubator source code) labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Theia UI frontend Trace Server Involve changes in the trace server itself (in the incubator source code)
Projects
None yet
Development

No branches or pull requests

1 participant