Skip to content

Commit a59881d

Browse files
provided the final fix for error handling
1 parent 27e4e0a commit a59881d

File tree

3 files changed

+3
-33
lines changed

3 files changed

+3
-33
lines changed

src/clients/AasRepositoryClient.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ export class AasRepositoryClient {
7171
};
7272
} catch (err) {
7373
const customError = handleApiError(err);
74-
console.log('Error:', customError);
7574
return { success: false, error: customError };
7675
}
7776
}
@@ -101,7 +100,6 @@ export class AasRepositoryClient {
101100
return { success: true, data: convertApiAasToCoreAas(result) };
102101
} catch (err) {
103102
const customError = handleApiError(err);
104-
console.log('Error:', customError);
105103
return { success: false, error: customError };
106104
}
107105
}
@@ -133,7 +131,6 @@ export class AasRepositoryClient {
133131
return { success: true, data: result };
134132
} catch (err) {
135133
const customError = handleApiError(err);
136-
console.log('Error:', customError);
137134
return { success: false, error: customError };
138135
}
139136
}
@@ -165,8 +162,6 @@ export class AasRepositoryClient {
165162
return { success: true, data: convertApiAasToCoreAas(result) };
166163
} catch (err) {
167164
const customError = handleApiError(err);
168-
//console.log('Error:', customError);
169-
console.log(`Error: field: ${customError.field}, message: ${customError.message}`);
170165
return { success: false, error: customError };
171166
}
172167
}
@@ -201,7 +196,6 @@ export class AasRepositoryClient {
201196
return { success: true, data: result };
202197
} catch (err) {
203198
const customError = handleApiError(err);
204-
console.log('Error:', customError);
205199
return { success: false, error: customError };
206200
}
207201
}
@@ -236,7 +230,6 @@ export class AasRepositoryClient {
236230
};
237231
} catch (err) {
238232
const customError = handleApiError(err);
239-
console.log('Error:', customError);
240233
return { success: false, error: customError };
241234
}
242235
}
@@ -271,7 +264,6 @@ export class AasRepositoryClient {
271264
return { success: true, data: result };
272265
} catch (err) {
273266
const customError = handleApiError(err);
274-
console.log('Error:', customError);
275267
return { success: false, error: customError };
276268
}
277269
}
@@ -302,7 +294,6 @@ export class AasRepositoryClient {
302294
return { success: true, data: result };
303295
} catch (err) {
304296
const customError = handleApiError(err);
305-
console.log('Error:', customError);
306297
return { success: false, error: customError };
307298
}
308299
}
@@ -334,7 +325,6 @@ export class AasRepositoryClient {
334325
return { success: true, data: result };
335326
} catch (err) {
336327
const customError = handleApiError(err);
337-
console.log('Error:', customError);
338328
return { success: false, error: customError };
339329
}
340330
}
@@ -372,7 +362,6 @@ export class AasRepositoryClient {
372362
return { success: true, data: result };
373363
} catch (err) {
374364
const customError = handleApiError(err);
375-
console.log('Error:', customError);
376365
return { success: false, error: customError };
377366
}
378367
}
@@ -417,7 +406,6 @@ export class AasRepositoryClient {
417406
};
418407
} catch (err) {
419408
const customError = handleApiError(err);
420-
console.log('Error:', customError);
421409
return { success: false, error: customError };
422410
}
423411
}
@@ -452,7 +440,6 @@ export class AasRepositoryClient {
452440
return { success: true, data: convertApiReferenceToCoreReference(result) };
453441
} catch (err) {
454442
const customError = handleApiError(err);
455-
console.log('Error:', customError);
456443
return { success: false, error: customError };
457444
}
458445
}
@@ -488,7 +475,6 @@ export class AasRepositoryClient {
488475
return { success: true, data: result };
489476
} catch (err) {
490477
const customError = handleApiError(err);
491-
console.log('Error:', customError);
492478
return { success: false, error: customError };
493479
}
494480
}

src/integration-tests/aasRepo.integration.test.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,9 @@ describe('AAS Repository Integration Tests', () => {
4444
expect(response.success).toBe(false);
4545
if (!response.success) {
4646
expect(response.error).toBeDefined();
47-
48-
//console.log('Error:', response.error);
49-
//console.log(`❌ Error fetching AAS with ID '${nonExistingId}':`, response.error.message || response.error);
50-
51-
let errorMessage = "Unknown error occurred.";
52-
if (response.error?.field) {
53-
errorMessage = ` Missing required field: ${response.error.field} - ${response.error.message}`;
54-
} else if (response.error?.message) {
55-
errorMessage = `${response.error.message}`;
56-
}
57-
console.log(
58-
`❌ Failed to fetch AAS with AAS ID: ${nonExistingId}, Error: ${errorMessage}` );
59-
60-
}
61-
});
47+
console.log('Error:', response.error);
48+
}
49+
});
6250

6351
test('should fetch all Asset Administration Shells', async () => {
6452
const response = await client.getAllAssetAdministrationShells({

src/lib/errorHandler.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
import { RequiredError } from '../generated';
22

33
export function handleApiError(err: unknown): RequiredError {
4-
//export function handleApiError(err: unknown, fields: Record<string, unknown>): RequiredError {, defaultField: string
5-
64
let message = 'Unknown error';
75
let statusCode = 'N/A';
8-
//let field = defaultField;
96
let field = 'N/A';
107

118
if (err instanceof RequiredError) {
@@ -22,5 +19,4 @@ export function handleApiError(err: unknown): RequiredError {
2219
}
2320

2421
return new RequiredError(field, ` message: ${message}`);
25-
//return new RequiredError(field, message);
2622
}

0 commit comments

Comments
 (0)