Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): support my-repo@[version] versions #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryshu
Copy link

@ryshu ryshu commented Mar 2, 2023

Closes #653

BREAKING CHANGE: Use sentry reponame@1.2.3 name instead of reponame-1.2.3 which doesn't match any convention in Sentry

@commit-lint
Copy link

commit-lint bot commented Mar 2, 2023

Bug Fixes

  • publish: support my-repo@[version] versions (b59c676)

Contributors

ryshu

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@ryshu ryshu force-pushed the fix/publish-does-not-match-requirement branch from 3065d96 to ce408e3 Compare March 2, 2023 08:13
@ryshu
Copy link
Author

ryshu commented Mar 2, 2023

Hi @lgaticaq,

Can you look into patching this problem as it makes the use of the plugin useless on our side.

For example:

  • 3.0.5-alpha5 => Real world sentry usecase
  • intranet-back-3.0.5-alpha.5 => Produced by this plugin

image

Thanks in advance

@wyardley
Copy link

wyardley commented Mar 3, 2023

Woo, thanks @ryshu

@ryshu
Copy link
Author

ryshu commented Mar 15, 2023

@Kl0ven @nils-van-zuijlen Do you think we should take over the maintenance of this utility? I think it could, if it works, really help us track our delivery adoptions on the various internal SpikeeLabs developments.

This repository doesn't seem to be maintained for a year :/

@ryshu
Copy link
Author

ryshu commented Mar 16, 2023

Woo, thanks @ryshu

Hi @wyardley

I fork this repository, add a test for Node 18, fix this problem here and publish it under the MIT license if you want: https://www.npmjs.com/package/semantic-release-sentry-releases

I try it tomorrow in our repository, and keep you updated if it works as expected.

@ryshu ryshu force-pushed the fix/publish-does-not-match-requirement branch from ce408e3 to b59c676 Compare March 16, 2023 23:26
Closes eclass#653

BREAKING CHANGE: Use sentry reponame@1.2.3 name instead of reponame-1.2.3 which doesn't match any convention in Sentry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support my-repo@[version] versions
2 participants