Alert user to packages of concern#2074
Alert user to packages of concern#2074ebkr wants to merge 8 commits intofeature/unlisted-notifications/trackingfrom
Conversation
ebkr
force-pushed
the
feature/unlisted-notifications/tracking
branch
from
a9deede to
24486d5
Compare
…le. Improved background/text clarity
TODO: - Auto-clear filter tag when no more remaining unlinked packages - Rename usages from Vulnerable to Concerning
ebkr
force-pushed
the
feature/unlisted-notifications/alert-vulnerable-packages
branch
from
829ddf3 to
df92b23
Compare
There was a problem hiding this comment.
Didn't build and test, but here's a review of the code and content.
Also, I think the out of sync icon should appear for all local mods + mods no longer found on Thunderstore that were marked safe, otherwise people can't tell at a glance what isn't being exported with their profiles. I think we discussed the export profile modal showing unexported mods, but the out of sync icon could probably be addressed through this PR.
| <p class="notification is-warning">It is generally recommended to remove mods that have been removed from Thunderstore.</p> | ||
| <div> | ||
| <hr/> | ||
| <p class="margin-bottom">This mod was originally downloaded using the Online section however no longer appears in the package cache.</p> |
There was a problem hiding this comment.
This mod was originally downloaded using the Online section however no longer appears in the package cache.
The mod wasn't necessarily downloaded from the Online section, it could've been downloaded from the website. The phrase "Package Cache" also sounds like it describes the "cache" folder next to the mod manager's "profiles" folder, so we should probably call it something else.
I would reword this whole section to this:
This mod was originally downloaded from Thunderstore, but can no longer be found on the site.
Mods may be removed at the author's request, for rule violations, or while undergoing verification by moderators.
Other people will be unable to import this mod from exported profiles.
| <template v-slot:description> | ||
| <p class='card-timestamp' v-if="mod.getInstalledAtTime() !== 0"><strong>Installed on:</strong> {{ getReadableDate(mod.getInstalledAtTime()) }}</p> | ||
| <div class="notification is-warning" v-if="isConcerningPackage(props.mod)"> | ||
| <p>This package was originally downloaded from Thunderstore however can no longer be found.</p> |
There was a problem hiding this comment.
This package was originally downloaded from Thunderstore however can no longer be found.
The wording here is awkward. Try:
This mod was originally downloaded from Thunderstore, but can no longer be found on the site.
It is recommended that you remove this mod.
It's less descriptive but we can add the extra info to the modal that opens.
|
|
||
| <template> | ||
| <div class="notification is-concern margin-right" v-show="hasConcerningPackages"> | ||
| <span>You have packages that can no longer be found on Thunderstore.</span> <a href="#" @click.stop.prevent="addUnlinkedFilter">Click here to review packages.</a> |
There was a problem hiding this comment.
Might as well call it a "mod" everywhere since that's what we do elsewhere in the mod manager.
| <p>Mods can be removed due to the author's request or due to violating Thunderstore's package policies.</p> | ||
| <p><strong>It is recommended to remove this mod.</strong></p> | ||
| <button v-if="isConcerningPackage(props.mod)" class="button" @click.stop.prevent="openReviewModal"> | ||
| Review package |
There was a problem hiding this comment.
"Review package" > "Review mod"
3 participants
Alerting users to packages of concern
Identifies mods no longer available on Thunderstore and gives the user a choice on how to proceed
How does it work
Based on the tracking in #2071
Mods can be taken down for several reasons, and this informs the user when it has happened.
This implementation adds a new kind of UX flow where clicking the review banner will now filter the local mod list. This is an optional step but makes the identified packages easier to discover. There is now a single tag that can be visibly applied, and auto-deselects once all packages have been resolved.
A package can be reviewed by expanding and clicking on the "Review package" button within the notification box. The user is then asked to either mark a package as safe, or to remove the mod.
Screenshots
Identified package in regular mod list
Narrowed scope
Searching is disabled when scope is narrowed
Expanded content
Review modal
Marked as safe
Light theme examples