Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add I18n Chinese #1367

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add I18n Chinese #1367

wants to merge 10 commits into from

Conversation

TianMengLucky
Copy link

@TianMengLucky TianMengLucky mentioned this pull request Jun 17, 2024
Open
AdamHebby
AdamHebby reviewed Jun 18, 2024
View reviewed changes
Copy link

@AdamHebby AdamHebby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on existing code, the standard here is to have spaces around brackets.

I haven't spotted any other issues.

src/App.vue Outdated Show resolved Hide resolved
@TianMengLucky @AdamHebby
Update src/App.vue
07601fe 
Co-authored-by: Adam Hebden <adamhebden56@gmail.com>
@TianMengLucky TianMengLucky mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamHebby AdamHebby AdamHebby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TianMengLucky @AdamHebby @lolligoo