benchmark: limit to 15

Author: tmc

syscall_bench_test.go

@@ -5,17 +5,9 @@ package purego
 
 import (
 	"fmt"
-	"runtime"
 	"testing"
 )
 
-// shouldSkipCallback returns true if callback tests should be skipped for the given arg count
-func shouldSkipCallback(nargs int) bool {
-	// Callbacks with >15 args have architectural limitations on all platforms
-	// The callback assembly only saves register arguments, not stack arguments
-	return nargs > 15
-}
-
 // BenchmarkCallingMethods compares RegisterFunc, SyscallN, and Callback methods
 func BenchmarkCallingMethods(b *testing.B) {
 	testCases := []struct {
@@ -30,11 +22,6 @@ func BenchmarkCallingMethods(b *testing.B) {
 		{5, noop5, 0, []uintptr{1, 2, 3, 4, 5}},
 		{10, noop10, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}},
 		{15, noop15, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15}},
-		{16, noop16, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16}},
-		{17, noop17, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17}},
-		{18, noop18, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18}},
-		{19, noop19, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19}},
-		{20, noop20, 0, []uintptr{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20}},
 	}
 
 	// Create callbacks once for all tests
@@ -46,13 +33,6 @@ func BenchmarkCallingMethods(b *testing.B) {
 	b.Run("RegisterFunc", func(b *testing.B) {
 		for _, tc := range testCases {
 			b.Run(fmt.Sprintf("%dargs", tc.n), func(b *testing.B) {
-				if tc.n > 15 {
-					b.Skipf("RegisterFunc with >15 args requires custom implementation")
-				}
-				if shouldSkipCallback(tc.n) {
-					b.Skipf("Callbacks with %d args not supported (callback assembly limitation on %s/%s)", tc.n, runtime.GOOS, runtime.GOARCH)
-				}
-
 				var registerFn any
 				switch tc.n {
 				case 1:
@@ -115,9 +95,6 @@ func BenchmarkCallingMethods(b *testing.B) {
 	b.Run("SyscallN", func(b *testing.B) {
 		for _, tc := range testCases {
 			b.Run(fmt.Sprintf("%dargs", tc.n), func(b *testing.B) {
-				if shouldSkipCallback(tc.n) {
-					b.Skipf("Callbacks with %d args not supported (callback assembly limitation on %s/%s)", tc.n, runtime.GOOS, runtime.GOARCH)
-				}
 				b.ResetTimer()
 				for i := 0; i < b.N; i++ {
 					SyscallN(tc.fnPtr, tc.args...)
@@ -130,9 +107,6 @@ func BenchmarkCallingMethods(b *testing.B) {
 	b.Run("Callback", func(b *testing.B) {
 		for _, tc := range testCases {
 			b.Run(fmt.Sprintf("%dargs", tc.n), func(b *testing.B) {
-				if shouldSkipCallback(tc.n) {
-					b.Skipf("Callbacks with %d args not supported (callback assembly limitation on %s/%s)", tc.n, runtime.GOOS, runtime.GOARCH)
-				}
 				b.ResetTimer()
 				for i := 0; i < b.N; i++ {
 					SyscallN(tc.fnPtr, tc.args...)