Skip to content

Commit b236292

Browse files
committed
Review comments #1.
1 parent da320e5 commit b236292

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

balancer/rls/internal/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func newRLSClient(cc *grpc.ClientConn, dialTarget string, rpcTimeout time.Durati
6262
}
6363
}
6464

65-
type lookupCallback func(target []string, headerData string, err error)
65+
type lookupCallback func(targets []string, headerData string, err error)
6666

6767
// lookup starts a RouteLookup RPC in a separate goroutine and returns the
6868
// results (and error, if any) in the provided callback.

balancer/rls/internal/client_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func TestLookupFailure(t *testing.T) {
7575
return
7676
}
7777
if len(targets) != 0 || headerData != "" {
78-
errCh <- fmt.Errorf("rlsClient.lookup() = (%v, %s), should be empty strings", targets, headerData)
78+
errCh <- fmt.Errorf("rlsClient.lookup() = (%v, %s), want (nil, \"\")", targets, headerData)
7979
return
8080
}
8181
errCh <- nil

0 commit comments

Comments
 (0)