Skip to content

Commit 542973a

Browse files
committed
Review comments #1.
1 parent 33c1803 commit 542973a

File tree

9 files changed

+1813
-1701
lines changed

9 files changed

+1813
-1701
lines changed

xds/internal/client/client.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ func RegisterAPIClientBuilder(b APIClientBuilder) {
5555
m[b.Version()] = b
5656
}
5757

58-
// GetAPIClientBuilder returns the client builder registered for the provided
58+
// getAPIClientBuilder returns the client builder registered for the provided
5959
// xDS transport API version.
60-
func GetAPIClientBuilder(version version.TransportAPI) APIClientBuilder {
60+
func getAPIClientBuilder(version version.TransportAPI) APIClientBuilder {
6161
if b, ok := m[version]; ok {
6262
return b
6363
}
@@ -212,7 +212,7 @@ type Options struct {
212212

213213
// Function to be overridden in tests.
214214
var newAPIClient = func(apiVersion version.TransportAPI, cc *grpc.ClientConn, opts BuildOptions) (APIClient, error) {
215-
cb := GetAPIClientBuilder(apiVersion)
215+
cb := getAPIClientBuilder(apiVersion)
216216
if cb == nil {
217217
return nil, fmt.Errorf("no client builder for xDS API version: %v", apiVersion)
218218
}
@@ -228,6 +228,9 @@ var newAPIClient = func(apiVersion version.TransportAPI, cc *grpc.ClientConn, op
228228
// ClientConn.
229229
//
230230
// Implements UpdateHandler interface.
231+
// TODO(easwars): Make a wrapper struct which implements this interface in the
232+
// style of ccBalancerWrapper so that the Client type does not implement these
233+
// exported methods.
231234
type Client struct {
232235
done *grpcsync.Event
233236
opts Options

0 commit comments

Comments
 (0)