Lint before syncing

I'm not proud of the code here, but cli ui sucks and makes outputting
stuff a pain in the ass.
What this does is effectively just run the linter on the changed file
before we sync it, most of the changes are just making the canvas gem
not output so that we can manage in the context of the new spin group or
something?

Author: kylebyrne

lib/canvas/dev_server/syncer.rb

@@ -8,6 +8,10 @@ def sync_file(path)
           return if path.nil?
           relative_path = Pathname.new(path).relative_path_from(Dir.getwd)
           CLI::UI::Spinner.spin("Syncing #{relative_path}") {
+            error_checks = Canvas::Lint.new.run([relative_path.to_s], nil)
+
+            raise "Failed Linting #{relative_path}" if error_checks.any?
+
             Canvas::Client.new.post(
               "/test_site_sync",
               body: {

lib/canvas/lint.rb

@@ -5,29 +5,37 @@
 module Canvas
   #:documented:
   class Lint
-    def run(scoped_files)
-      output_context = CLI::UI::SpinGroup.new(auto_debrief: false)
-
+    def run(scoped_files, output_context = CLI::UI::SpinGroup.new(auto_debrief: false))
       @checks = Checks.registered.map(&:new)
 
       @checks.each do |check|
         run_check(check, output_context, scoped_files)
       end
 
-      output_context.wait
+      if output_context
+        output_context.wait
+      end
 
       if @checks.any?(&:failed?)
-        puts debrief_message
-        exit 1
+        if output_context
+          puts debrief_message
+          exit 1
+        else
+          return @checks.filter(&:failed?)
+        end
       end
     end
 
     private
 
     def run_check(check, output_context, scoped_files)
-      output_context.add(check.class.name) do
+      if output_context
+        output_context.add(check.class.name) do
+          check.run(scoped_files)
+          raise if check.offenses.any?
+        end
+      else
         check.run(scoped_files)
-        raise if check.offenses.any?
       end
     end