Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xarray ERA5 notebook #188

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

rabernat
Copy link
Contributor

No description provided.

@rabernat rabernat marked this pull request as ready for review October 11, 2024 18:44
@rabernat
Copy link
Contributor Author

The linting here is annoying and not helpful. Could we disable for the notebooks?

@paraseba
Copy link
Contributor

The linting here is annoying and not helpful. Could we disable for the notebooks?

oh yeah, could you try to add the skip to the pyproject file?

@paraseba paraseba self-requested a review October 11, 2024 21:54
@paraseba
Copy link
Contributor

@rabernat I don't think it will be too relevant, but for a fairer comparison, when you load the data with icechunk, you should do it using a fresh IcechunkStore instance. The one you have has the manifest cached, so it's probably not fetching it and parsing it.

@paraseba
Copy link
Contributor

Are you planning to merge this one @rabernat ?

@rabernat
Copy link
Contributor Author

I've made a few changes to this notebook. Please don't merge yet.

In general, I think we want to understand the role the notebooks are playing in the project. Are they documentation? Examples? Are they maintained? Tested?

My view right now is that the notebooks folder should be used to gather useful example code but shouldn't be considered official documentation. We should put a README and a disclaimer that the notebooks are loosely maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants