Skip to content

Commit 2c817b3

Browse files
Zuulopenstack-gerrit
Zuul
authored andcommitted
Merge "Add basic storage test to test config overrides" into stable/2023.2
2 parents 2ca4b1b + 5af65f9 commit 2c817b3

File tree

2 files changed

+61
-0
lines changed

2 files changed

+61
-0
lines changed

designate/tests/test_central/test_service.py

+31
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,37 @@ def test_create_zone_over_quota(self):
533533

534534
self.assertEqual(exceptions.OverQuota, exc.exc_info[0])
535535

536+
def test_create_zone_custom_ttl(self):
537+
self.config(default_ttl=30)
538+
539+
values = dict(
540+
name='example.com.',
541+
email='info@example.com',
542+
type='PRIMARY',
543+
ttl=90,
544+
)
545+
546+
zone = self.central_service.create_zone(
547+
self.admin_context, zone=objects.Zone.from_dict(values)
548+
)
549+
550+
self.assertEqual(90, zone.ttl)
551+
552+
def test_create_zone_override_default_ttl(self):
553+
self.config(default_ttl=30)
554+
555+
values = dict(
556+
name='example.com.',
557+
email='info@example.com',
558+
type='PRIMARY'
559+
)
560+
561+
zone = self.central_service.create_zone(
562+
self.admin_context, zone=objects.Zone.from_dict(values)
563+
)
564+
565+
self.assertEqual(30, zone.ttl)
566+
536567
def test_create_subzone(self):
537568
# Create the Parent Zone using fixture 0
538569
parent_zone = self.create_zone(fixture=0)

designate/tests/test_storage/test_storage.py

+30
Original file line numberDiff line numberDiff line change
@@ -681,6 +681,36 @@ def test_create_zone_duplicate(self):
681681

682682
self.assertEqual(exceptions.DuplicateZone, exc.exc_info[0])
683683

684+
def test_create_zone_standard_ttl(self):
685+
values = self.get_zone_fixture()
686+
new_zone = self.storage.create_zone(
687+
self.admin_context, zone=objects.Zone.from_dict(values)
688+
)
689+
690+
# default fallback ttl is 3600 when no ttl value is provided.
691+
self.assertEqual(3600, new_zone.ttl)
692+
693+
def test_create_zone_custom_ttl(self):
694+
self.config(default_ttl=60)
695+
696+
values = self.get_zone_fixture()
697+
values['ttl'] = 30
698+
new_zone = self.storage.create_zone(
699+
self.admin_context, zone=objects.Zone.from_dict(values)
700+
)
701+
702+
self.assertEqual(30, new_zone.ttl)
703+
704+
def test_create_zone_override_default_ttl(self):
705+
self.config(default_ttl=60)
706+
707+
values = self.get_zone_fixture()
708+
new_zone = self.storage.create_zone(
709+
self.admin_context, zone=objects.Zone.from_dict(values)
710+
)
711+
712+
self.assertEqual(60, new_zone.ttl)
713+
684714
def test_find_zones(self):
685715
self.config(quota_zones=20)
686716

0 commit comments

Comments
 (0)