Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style.setProperty on IE doesn't convert 'float' to 'styleFloat' #108

Open
GoogleCodeExporter opened this issue Jun 12, 2015 · 4 comments
Open

Comments

@GoogleCodeExporter
Copy link

In "DOM/style/CSSStyleDeclaration.js", in the definition for
"CSSStyleDeclaration", under the code block "@MSIE.+win", the function
'setProperty' which reads:

{{{
if (priority == "important") {
     style.cssText += format(";%1:%2!important;", propertyName, value);
} else {
     style.setAttribute(ViewCSS.toCamelCase(propertyName), value);
}
}}}

doesn't fix 'styleFloat' as getPropertyValue above does:

{{{
getPropertyValue: function(style, propertyName) {
     return propertyName == "float" ? style.styleFloat :
style[ViewCSS.toCamelCase(propertyName)];
}
}}}

Original issue reported on code.google.com by timcamer...@gmail.com on 9 May 2009 at 7:10

@GoogleCodeExporter
Copy link
Author

Additionally, for MSIE, CSSStyleDeclaration should be bound to element.style 
objects,
which works fine (until cssText is overwritten, in which case the function 
bindings
turn into functions).

Original comment by timcamer...@gmail.com on 9 May 2009 at 7:56

@GoogleCodeExporter
Copy link
Author

Original comment by dean.edw...@gmail.com on 21 Jun 2009 at 4:05

  • Changed state: Accepted
  • Added labels: Browser-MSIE, Module-base2.DOM, Priority-Medium, Type-Defect

@GoogleCodeExporter
Copy link
Author

re comment #1:

Binding the style object results in much slower binding times for MSIE.

Do you really need this?

Original comment by dean.edw...@gmail.com on 7 Jul 2009 at 5:05

@GoogleCodeExporter
Copy link
Author

Original comment by dean.edw...@gmail.com on 7 Jul 2009 at 5:33

  • Changed state: Started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant