Fixes numCols calculation to allow for full container width responsive implementations#42
Open
stevenamoody wants to merge 1 commit intoe-oj:masterfrom
Open
Fixes numCols calculation to allow for full container width responsive implementations#42stevenamoody wants to merge 1 commit intoe-oj:masterfrom
stevenamoody wants to merge 1 commit intoe-oj:masterfrom
Conversation
Author
|
somehow i goof'd in branching here. i'll figure it out and reopen |
…e implementations
Author
|
Reopened, I originally branched from master and it appears your dev branch has diverged from master. Targeting master as the base to illustrate my changes but let me know and I can re-target to dev if you'd like to merge there. |
|
Confirmed as working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to have a responsive layout that takes up the full width of the container, the numCols calculation should take into account the extra gutter space. See the test I added in
test/grid-responsive.html