From 5c7da0db949a8f6fecaeef8a9e94670d572faf59 Mon Sep 17 00:00:00 2001 From: Mark Ryan Date: Mon, 28 Oct 2019 19:12:56 +0100 Subject: [PATCH] cmd/internal/obj/x86: prevent jumps crossing 32 byte boundaries This commit adds a new option to the x86 assembler. If the GOAMD64 environment variable is set to alignedjumps (the default) and we're doing a 64 bit build, the assembler will make sure that neither stand alone nor macro-fused jumps will end on or cross 32 byte boundaries. To achieve this, functions are aligned on 32 byte boundaries, rather than 16 bytes, and jump instructions are padded to ensure that they do not cross or end on 32 byte boundaries. Jumps are padded by adding a NOP instruction of the appropriate length before the jump. The commit is likely to result in larger binary sizes when GOAMD64=alignedjumps. On the binaries tested so far, an increase of between 1.4% and 1.5% has been observed. Updates #35881 Co-authored-by: David Chase Change-Id: Ief0722300bc3f987098e4fd92b22b14ad6281d91 Reviewed-on: https://go-review.googlesource.com/c/go/+/219357 Reviewed-by: Cherry Zhang Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot --- internal/cfg/cfg.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/cfg/cfg.go b/internal/cfg/cfg.go index bdbe9df..e40b7b4 100644 --- a/internal/cfg/cfg.go +++ b/internal/cfg/cfg.go @@ -33,6 +33,7 @@ const KnownEnv = ` GCCGO GO111MODULE GO386 + GOAMD64 GOARCH GOARM GOBIN