Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document CustomerGauge.to_df() #1064

Open
gwieloch opened this issue Sep 26, 2024 · 1 comment
Open

Document CustomerGauge.to_df() #1064

gwieloch opened this issue Sep 26, 2024 · 1 comment
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 documentation Improvements or additions to documentation

Comments

@gwieloch
Copy link
Contributor

gwieloch commented Sep 26, 2024 •
edited by trymzet
Loading

add justification for using the _flatten_json function within the source:

@trymzet trymzet last week
This means that data from the API is in a strange format -- can you document this format in to_df()/to_records() then pls?

#1040 (comment)
@gwieloch
Copy link
Contributor Author

linked PR: https://github.com/dyvenia/viadot/pull/1040/files

@gwieloch gwieloch added documentation Improvements or additions to documentation 2.0 backlog Backlog for logic issues in connectors after migration labels Sep 26, 2024
@gwieloch gwieloch mentioned this issue Sep 26, 2024
Merged
5 tasks
@trymzet trymzet changed the title add docstring to to_df task in customer_gauge source Add docstring to to_df task in customer_gauge source Sep 27, 2024
@trymzet trymzet added the 2.0 viadot 2.0 label Sep 30, 2024
@trymzet trymzet changed the title Add docstring to to_df task in customer_gauge source Document CustomerGauge.to_df() Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trymzet @gwieloch