Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #73

Merged
merged 3 commits into from
Mar 17, 2016
Merged

Documentation #73

merged 3 commits into from
Mar 17, 2016

Conversation

dbrian56
Copy link
Contributor

Hi, I changed three files and I thought I would try a pull request before I went any further. Let me know your thoughts on this stuff if any and whether I'm doing this Git thing right. Thanks!

Installing dyn is simple via `pip <http://www.pip-installer.org/>`_.
The easiest way to install the Dyn module is via ‘pip’.

1. Go to <http://www.pip-installer.org/>’, download and install ‘pip’.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally of the opinion that if someone is on github looking at the source code, that we probably don't need to tell them to download and install pip, or that they should be using a Terminal application. That being said, I guess it's not the end of the world to add this, just that it might be out of place for the intended audience

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally understand that and questioned whether to put this in or not, but I decided to drop it in because I tend to look at most things as "baby's first [insert whatever technology]" when I document them. Making it as accessible as possible is for the best, I think.

@moogar0880
Copy link
Contributor

Looks good to me, most of the things I noticed were really just nit-picky things, nothing substantial.

@dbrian56 do you have permissions to merge this PR or do you need a merge?

@dbrian56
Copy link
Contributor Author

I'm pretty sure I don't have write access, so I think you would need to merge lest you guys give that permission to me.

@Marchowes
Copy link
Contributor

+1 LGTM. I'll Merge.

Marchowes added a commit that referenced this pull request Mar 17, 2016
@Marchowes Marchowes merged commit e6bc9e4 into dyninc:master Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants