Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to evaluate expression if a number starts with a . (dot) #43

Closed
sgokuladas opened this issue Jun 20, 2016 · 4 comments
Closed

Unable to evaluate expression if a number starts with a . (dot) #43

sgokuladas opened this issue Jun 20, 2016 · 4 comments
Labels
bug
Milestone
1.3.4.7

Comments

@sgokuladas
Copy link

The interpreter cannot evaluate a formula if I say interpreter.evaluate("1 + .2")

Note: interpreter.evaluate("1 + 0.2") works
@sgokuladas sgokuladas changed the title Unable to evaluate expression with . without a zero character Unable to evaluate expression with . Jun 20, 2016
@davideicardi davideicardi added this to the v1.4.0 milestone Jun 20, 2016
@davideicardi
Copy link
Member

You are right, this is a bug. I added this is my todo list but I don't know when I can work on it.
Eventually I appreciate any help (pull request).

@sgokuladas
Copy link
Author

sgokuladas commented Jun 20, 2016 •
edited
Loading

I'm new around here, but I'll give it a go if I get some time next week

@davideicardi davideicardi changed the title Unable to evaluate expression with . Unable to evaluate expression if a number starts with a . (dot) Jul 30, 2016
JustinRChou added a commit to JustinRChou/DynamicExpresso that referenced this issue Oct 8, 2016
@JustinRChou
Fix for dynamicexpresso#43 when .2 was not parsing is a Real Literal.
ce001f6 
Added additional Unit Tests for the new parsing.
@JustinRChou
Copy link
Contributor

JustinRChou commented Oct 8, 2016 •
edited
Loading

Solution might not be as clean without changing more code in my fork.

@JustinRChou JustinRChou mentioned this issue Oct 8, 2016
Merged
JustinRChou added a commit to JustinRChou/DynamicExpresso that referenced this issue Oct 10, 2016
@JustinRChou
Revert "Fix for dynamicexpresso#43 when .2 was not parsing is a Real …
039fe8c 
…Literal."

This reverts commit ce001f6.
JustinRChou added a commit to JustinRChou/DynamicExpresso that referenced this issue Oct 10, 2016
@JustinRChou
Added more unit tests for issue dynamicexpresso#43
cb4ce68 
Added more unit tests for issue dynamicexpresso#43 to take into account .2f or .5m
formats.
@davideicardi
Copy link
Member

Fixed, thanks to @JustinRChou

@davideicardi davideicardi modified the milestones: 1.4, 1.3.4.7 Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.4.7
Development

No branches or pull requests
3 participants
@davideicardi @JustinRChou @sgokuladas