Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUESTION/BUG referencing a page changed to blog, but not published allows access to published posts #24

Open
muskie9 opened this issue Jul 29, 2019 · 1 comment
Labels

Comments

@muskie9
Copy link
Member

muskie9 commented Jul 29, 2019

Steps to Reproduce

  • Install dynamic/silverstripe-elemental-blog
  • Change a page to Blog type (save, don't publish)
  • Add a BlogPost record in the blog (publish)
  • Add a Blog element to another page (publish page)
    • View page on FE

Expected Behavior

It would be expected that the blog posts should not display as the page that is now a Blog is in a saved state, but not published.

Actual Behavior

Blog posts display within the blog element on the FE.

@muskie9 muskie9 added this to the 2.1.2 milestone Jul 29, 2019
@muskie9
Copy link
Member Author

muskie9 commented Jul 29, 2019

This may be expected behavior as the logic is written:

  • Posts by category
  • Posts by blog
  • Posts that are published

In the event that a blog is selected, but isn't in a published state, it will always fall back to pulling all published posts ordered by published date (respecting the set limit).

@dynamic/dynamic-opensource while we can't necessarily change the expected behavior in the next release, it's worth reviewing to make sure if this is the expected behavior.

If I select a blog from the dropdown, I would presume it would be strict to that blog, even if it is unpublished, resulting in an empty list and the expected message on the frontend. Alternatively, clearly describing what the behavior is for content managers to reduce any confusion.

I'm curious as to what others would expect the behavior to be in the above case.

@muskie9 muskie9 removed this from the 2.1.2 milestone Jul 29, 2019
@muskie9 muskie9 removed the bug label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant