Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit share frequency #19

Open
cgay opened this issue Dec 24, 2020 · 1 comment
Open

Limit share frequency #19

cgay opened this issue Dec 24, 2020 · 1 comment
Labels
P3 Priority 3

Comments

@cgay
Copy link
Member

cgay commented Dec 24, 2020

To avoid disk full DOS attacks, limit how often one client can share code. Guessing it has to be IP based.

@cgay cgay added P1 Priority 1 P3 Priority 3 and removed P1 Priority 1 labels Dec 24, 2020
@cgay
Copy link
Member Author

cgay commented Dec 29, 2020

I ameliorated this via the nginx rate limiting configs so I'm going to downgrade priority. It's still quite possible for a determined person to fill up the disk but it should now take them a lot more time.

TODO:

  • application level detection that adds IPs to a deny list, at least until server restart. (git stash pop rate-limit)
  • display a decent error message when the 503 response is received by the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority 3
Projects
None yet
Development

No branches or pull requests

1 participant