Can pass keywords to with-tracing.

These keywords get passed to trace-push.

Author: waywardmonkeys

documentation/source/index.rst

@@ -194,7 +194,18 @@ tasks may find it easier to track their own spans separately.
        with-tracing ("Span description")
          trace-add-data("Table", "users");
          ...
-       end with-tracing
+       end with-tracing;
+
+    :description:
+
+      The ``with-tracing`` macro can also take any keywords that :gf:`trace-push`
+      takes and will pass them along:
+
+      .. code-block:: dylan
+
+         with-tracing ("Span description", sampler: never-sample)
+           ...
+         end with-tracing;
 
 Spans
 -----

tests/tracing-core/tracing-core-test-suite.dylan

@@ -18,6 +18,7 @@ define suite tracing-core-test-suite ()
   test test-nested-traces;
   test test-trace-host;
   test test-with-tracing;
+  test test-with-tracing-never-sampling;
   test test-add-duration-to-timestamp;
 end suite;
 
@@ -181,6 +182,12 @@ define test test-with-tracing ()
   end with-tracing;
 end test;
 
+define test test-with-tracing-never-sampling ()
+  with-tracing ("Outer", sampler: never-sample)
+    assert-equal(0, trace-current-spans().size);
+  end with-tracing;
+end test;
+
 define test test-add-duration-to-timestamp ()
   let timestamp = make(<timestamp>, days: 0, seconds: 86398, microseconds: 500000);
   let new-timestamp = add-duration-to-timestamp(timestamp, 1, 500000);

tracing-core/trace.dylan

@@ -63,10 +63,10 @@ define function trace-set-host (host :: <string>) => ();
 end function trace-set-host;
 
 define macro with-tracing
-  { with-tracing (?description:expression) ?:body end }
+  { with-tracing (?description:expression, #rest ?keys:expression) ?:body end }
  =>
   {
-    let span = trace-push(?description);
+    let span = trace-push(?description, ?keys);
     block ()
       ?body
     cleanup