don't send message if max volume below threshold

Author: 2fours

res/values/strings.xml

@@ -331,4 +331,5 @@
     <string name="voice_help_3">Touch on a voice message to play, touch again to stop.</string>
     <string name="voice_help_4">New voice messages will play automatically for the open chat tab.</string>
     <string name="close">close</string>
+    <string name="no_audio_detected">no audio detected - not sending voice message</string>
 </resources>

src/com/twofours/surespot/voice/VoiceController.java

@@ -39,6 +39,7 @@ public class VoiceController {
 	private static String mFileName = null;
 	private static String mUsername = null;
 
+	public static final int SEND_THRESHOLD = 5000;
 	public static final int MAX_TIME = 10000;
 	public static final int INTERVAL = 50;
 
@@ -261,61 +262,69 @@ public synchronized static void stopRecording(Activity activity, boolean send) {
 	}
 
 	private synchronized static void sendVoiceMessage(final Activity activity) {
-		new AsyncTask<Void, Void, String>() {
+		int maxVolume = mEnvelopeView.getMaxVolume();
+		SurespotLog.v(TAG, "max recorded volume: %d", maxVolume);
+		if (maxVolume < SEND_THRESHOLD) {
+			Utils.makeToast(activity, activity.getString(R.string.no_audio_detected));
+		}
+		else {
+			new AsyncTask<Void, Void, String>() {
 
-			@Override
-			protected String doInBackground(Void... params) {
-				// convert to AAC
-				FileInputStream fis;
-				try {
-					fis = new FileInputStream(mFileName);
+				@Override
+				protected String doInBackground(Void... params) {
+					// convert to AAC
+					FileInputStream fis;
+					try {
+						fis = new FileInputStream(mFileName);
 
-					String outFile = File.createTempFile("record", ".aac").getAbsolutePath();
-					mEncoder.init(16000, 1, mSampleRate, 16, outFile);
+						String outFile = File.createTempFile("record", ".aac").getAbsolutePath();
+						mEncoder.init(16000, 1, mSampleRate, 16, outFile);
 
-					mEncoder.encode(Utils.inputStreamToBytes(fis));
-					mEncoder.uninit();
+						mEncoder.encode(Utils.inputStreamToBytes(fis));
+						mEncoder.uninit();
 
-					// convert to m4a (gingerbread can't play the AAC for some bloody reason).
-					final String m4aFile = File.createTempFile("record", ".m4a").getAbsolutePath();
-					new AACToM4A().convert(activity, outFile, m4aFile);
+						// convert to m4a (gingerbread can't play the AAC for some bloody reason).
+						final String m4aFile = File.createTempFile("record", ".m4a").getAbsolutePath();
+						new AACToM4A().convert(activity, outFile, m4aFile);
 
-					// delete files
-					new File(outFile).delete();
-					new File(mFileName).delete();
+						// delete files
+						new File(outFile).delete();
+						new File(mFileName).delete();
 
-					return m4aFile;
+						return m4aFile;
 
-				}
+					}
 
-				catch (IOException e) {
-					SurespotLog.w(TAG, e, "sendVoiceMessage");
+					catch (IOException e) {
+						SurespotLog.w(TAG, e, "sendVoiceMessage");
+					}
+					return null;
 				}
-				return null;
-			}
 
-			protected void onPostExecute(final String encryptedVoiceMessageFile) {
-				if (encryptedVoiceMessageFile != null) {
+				protected void onPostExecute(final String encryptedVoiceMessageFile) {
+					if (encryptedVoiceMessageFile != null) {
 
-					ChatUtils.uploadVoiceMessageAsync(activity, MainActivity.getChatController(), MainActivity.getNetworkController(),
-							Uri.fromFile(new File(encryptedVoiceMessageFile)), mUsername, new IAsyncCallback<Boolean>() {
+						ChatUtils.uploadVoiceMessageAsync(activity, MainActivity.getChatController(), MainActivity.getNetworkController(),
+								Uri.fromFile(new File(encryptedVoiceMessageFile)), mUsername, new IAsyncCallback<Boolean>() {
 
-								@Override
-								public void handleResponse(Boolean result) {
-									if (result) {
-										// delete m4a
-										new File(encryptedVoiceMessageFile).delete();
+									@Override
+									public void handleResponse(Boolean result) {
+										if (result) {
+											// delete m4a
+											new File(encryptedVoiceMessageFile).delete();
+										}
 									}
-								}
-							});
+								});
 
-				}
-				else {
-					Utils.makeToast(activity, "error sending message");
-				}
+					}
+					else {
+						Utils.makeToast(activity, "error sending message");
+					}
 
-			};
-		}.execute();
+				};
+
+			}.execute();
+		}
 
 	}
 

src/com/twofours/surespot/voice/VolumeEnvelopeView.java

@@ -13,6 +13,7 @@
 
 public class VolumeEnvelopeView extends View {
 	private static final String TAG = null;
+	private static int mMaxVolume;
 
 	/**
 	 * Constructor. This version is only needed if you will be instantiating the object manually (not from a layout XML file).
@@ -70,6 +71,9 @@ public void setNewVolume(int value, boolean redraw) {
 
 		if (value != 0) {
 			mEnvelope.add(value);
+			if (value > mMaxVolume) {
+				mMaxVolume = value;
+			}
 		}
 		else
 			if (!mEnvelope.isEmpty())
@@ -83,6 +87,7 @@ public void setNewVolume(int value, boolean redraw) {
 	}
 
 	public void clearVolume() {
+		mMaxVolume = 0;
 		mEnvelope.clear();
 		invalidate();
 	}
@@ -108,4 +113,8 @@ protected void onDraw(Canvas canvas) {
 	private Paint mEnvelopePaint;
 	private LinkedList<Integer> mEnvelope = new LinkedList<Integer>();
 	int mSize = 0;
+	
+	public int getMaxVolume() {
+		return mMaxVolume;
+	}
 }