Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Snake Case use #59

Open
Lucasmiguelmac opened this issue Aug 14, 2022 · 1 comment
Open

Remove Snake Case use #59

Lucasmiguelmac opened this issue Aug 14, 2022 · 1 comment

Comments

@Lucasmiguelmac
Copy link

Lucasmiguelmac commented Aug 14, 2022

Hello there.

I've seen a bad pattern here, and it is that snake_case is being used in this library.
This is a total bad practice and breaks patterns that are a standard across JS/TS libraries.

It may be ok to use snake_case with other programming languages (ie: Python), but when working with TypeScript or JavaScript, we should stick to using camelCase, or PascalCase when naming components and objects.

Take a look at any other JS/TS/Svelte library and you'll quickly notice that snake_case is not used anywhere.

@kamalkech
Copy link
Collaborator

@Lucasmiguelmac thank for ur investigation, if u look to react version i clean the code and i will do the same with svelte/solid versions, it s better to join to my discord if u have any questions + ideas ;) https://discord.gg/cAjxEsHe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants