Skip to content

Conversation

@aweell
Copy link
Collaborator

@aweell aweell commented Mar 31, 2022

Changes

  • Rename fileItemIconColor as deleteFileItemColor
  • Rename hoverFileItemIconBackgroundColor as hoverDeleteFileItemBackgroundColor and update value to color-grey-a-100
  • Rename activeFileItemIconBackgroundColor as activeDeleteFileItemBackgroundColor and update value to color-grey-a-300
  • Rename focusFileItemIconBackgroundColor as focusDeleteFileItemBackgroundColor

Closes #774

@aweell aweell linked an issue Mar 31, 2022 that may be closed by this pull request
@aweell aweell requested a review from aidamag April 1, 2022 07:09
@aidamag
Copy link
Contributor

aidamag commented Apr 1, 2022

I am not quite certain about changing fileItemIconColor to deleteFileItemColor because the first one is been applied in the preview icon, not in the delete icon. Maybe to add this deleteFileItemColor token instead of changing an existing one?

@aweell
Copy link
Collaborator Author

aweell commented Apr 1, 2022

I am not quite certain about changing fileItemIconColor to deleteFileItemColor because the first one is been applied in the preview icon, not in the delete icon. Maybe to add this deleteFileItemColor token instead of changing an existing one?

I think we should be using filePreviewIconColor since for that case has this token created for.

@aweell aweell merged commit 25ddbff into master Apr 8, 2022
@aweell aweell deleted the 774-create-doc-page-for-fileinput-component branch April 8, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create doc page for FileInput component

3 participants