Skip to content

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented May 23, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
To avoid creating a breaking change for now we will default the tabId value to the label if this one is set.

@Mil4n0r Mil4n0r self-assigned this May 26, 2025
@Jialecl Jialecl requested a review from Mil4n0r May 26, 2025 08:38
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, can you do a change in the stories so that we have both an example of top/left icon position with text and another one with no text? (instead of replacing it like you have done). That way we canmake sure that we are covering all scenarios.

@Jialecl
Copy link
Collaborator Author

Jialecl commented May 27, 2025

Looks good to me. However, can you do a change in the stories so that we have both an example of top/left icon position with text and another one with no text? (instead of replacing it like you have done). That way we canmake sure that we are covering all scenarios.

We do have already a few examples with icon and label with iconPosition top and left.
But I added them just in case since some of those cases have notification number.

@Jialecl Jialecl requested a review from Mil4n0r May 27, 2025 08:51
@Mil4n0r Mil4n0r merged commit 3b779a7 into master May 27, 2025
4 checks passed
@Mil4n0r Mil4n0r deleted the jialecl/tabs-improvement branch May 27, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants