Skip to content

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented May 15, 2025

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
With this change tabs can be used without a label as it is documented.

*Description
This is a major change due to a required prop tabId being added to the DxcTabs.Tab component. This prop allows the tabs component to identify each tab even if there is not a label present.

@Jialecl Jialecl marked this pull request as draft May 15, 2025 14:12
@Jialecl Jialecl marked this pull request as ready for review May 15, 2025 14:31
@Mil4n0r Mil4n0r merged commit c2aa807 into master May 19, 2025
4 checks passed
@Mil4n0r Mil4n0r deleted the jialecl-tabsId branch May 19, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants