Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Dec 3, 2024

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
The focus was not following the tabbing sequence in Dialog and Alert components when there was a component with the new Tooltip. It was an issue with the Focus Lock internal component.

Description

  • Fixed the issue. The MutationObserver from the FocusLock component was executing itself each time the focus changed, due to a flag of the observer ({ attributes: true }). Now it is only executing when the tree inside the component changes, which is the expected behavior.
    • Fixed some usual issues with the Focus Lock like the Date Input calendar focus return on close, added focus guards etc.
    • New tests.
  • Change Dialog's prop isCloseVisible to closable, to match the new Alert approach for this same property.

@Mil4n0r Mil4n0r self-requested a review December 3, 2024 13:53
@Mil4n0r Mil4n0r self-assigned this Dec 3, 2024
@GomezIvann GomezIvann marked this pull request as ready for review December 3, 2024 16:42
@Mil4n0r Mil4n0r self-requested a review December 4, 2024 13:53
@Mil4n0r Mil4n0r merged commit a5e32ba into master Dec 4, 2024
4 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/focus-lock-issue branch December 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants