Updates on the FocusLock and Dialog #2125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Purpose
The focus was not following the tabbing sequence in Dialog and Alert components when there was a component with the new Tooltip. It was an issue with the Focus Lock internal component.
Description
MutationObserverfrom theFocusLockcomponent was executing itself each time the focus changed, due to a flag of the observer ({ attributes: true }). Now it is only executing when the tree inside the component changes, which is the expected behavior.isCloseVisibletoclosable, to match the new Alert approach for this same property.