Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Oct 31, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Under certain interactions, the underline for the active item would move down until not being shown at all.

Additional context
It has been happening since DxcTabs API was refactorized to use compound component. A change in the dependency array to calculate the width and height was causing this problem.

Closes #2110

@Mil4n0r Mil4n0r marked this pull request as ready for review October 31, 2024 15:29
@GomezIvann GomezIvann self-requested a review November 4, 2024 08:59
@GomezIvann GomezIvann self-assigned this Nov 4, 2024
@Mil4n0r Mil4n0r marked this pull request as draft November 4, 2024 16:02
@Mil4n0r Mil4n0r marked this pull request as ready for review November 11, 2024 09:27
@GomezIvann GomezIvann merged commit abd3e71 into master Nov 12, 2024
3 of 4 checks passed
@GomezIvann GomezIvann deleted the Mil4n0r/fix_underline_tabs branch November 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The bottom border of the active tab disappears under certain conditions

3 participants