Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 14, 2024

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
The implementation of the Flex component has been updated to match the Grid counterpart. Now, the default value of the props is consistent with the flexbox container default values, and we only give value to the ones passed by the user.

Thanks to this, our props are more accurate to the formal definition of the CSS Flexbox and add the ones passed by the code users, as they would expect.

@GomezIvann GomezIvann marked this pull request as ready for review October 15, 2024 07:12
@Mil4n0r Mil4n0r self-requested a review October 15, 2024 09:42
@Mil4n0r Mil4n0r self-assigned this Oct 15, 2024
@Mil4n0r Mil4n0r merged commit a749132 into master Oct 15, 2024
4 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/flex-updates branch October 15, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants