Skip to content

Added custom tooltip to ApplicationLayout #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Added custom tooltip to ApplicationLayout #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a32de
Added DxcTooltip to application layout component
Mil4n0r May 10, 2024
db2a29f
Merge branch 'master' of github.com:dxc-technology/halstack-react int…
Mil4n0r Jul 10, 2024
7e0ab31
Fixed typo
Mil4n0r Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lib/src/common/variables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,7 +1357,7 @@ export const defaultTranslatedComponentLabels = {
logoAlternativeText: "Logo",
},
applicationLayout: {
visibilityToggleTitle: "Toggle visibility sidenav",
visibilityToggleTitle: "Toggle sidenav visibility",
},
alert: {
infoTitleText: "information",
Expand Down
18 changes: 10 additions & 8 deletions packages/lib/src/layout/ApplicationLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import DxcIcon from "../icon/Icon";
import DxcSidenav from "../sidenav/Sidenav";
import { SidenavContextProvider, useResponsiveSidenavVisibility } from "../sidenav/SidenavContext";
import useTranslatedLabels from "../useTranslatedLabels";
import DxcTooltip from "../tooltip/Tooltip";
import layoutIcons from "./Icons";
import AppLayoutPropsType, { AppLayoutMainPropsType } from "./types";

Expand Down Expand Up @@ -100,14 +101,15 @@ const DxcApplicationLayout = ({
<HeaderContainer>{headerContent}</HeaderContainer>
{sidenav && isResponsive && (
<VisibilityToggle>
<HamburgerTrigger
onClick={handleSidenavVisibility}
aria-label={visibilityToggleLabel ? undefined : translatedLabels.applicationLayout.visibilityToggleTitle}
title={translatedLabels.applicationLayout.visibilityToggleTitle}
>
<DxcIcon icon="Menu" />
{visibilityToggleLabel}
</HamburgerTrigger>
<DxcTooltip label={translatedLabels.applicationLayout.visibilityToggleTitle}>
<HamburgerTrigger
onClick={handleSidenavVisibility}
aria-label={visibilityToggleLabel ? undefined : translatedLabels.applicationLayout.visibilityToggleTitle}
>
<DxcIcon icon="Menu" />
{visibilityToggleLabel}
</HamburgerTrigger>
</DxcTooltip>
</VisibilityToggle>
)}
<BodyContainer>
Expand Down