Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented May 9, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
We are adding both advanced and opinionated tokens to the Contextual Menu component. Here are the proposed ones.

Advanced tokens

    fontFamily: CoreTokens.type_sans,
    backgroundColor: CoreTokens.color_white,
    borderColor: CoreTokens.color_grey_200,
    menuItemFontColor: CoreTokens.color_grey_900,
    menuItemFontSize: CoreTokens.type_scale_02,
    menuItemFontStyle: CoreTokens.type_normal,
    menuItemFontWeight: CoreTokens.type_regular,
    menuItemLineHeight: "24px",
    hoverMenuItemBackgroundColor: CoreTokens.color_grey_100,
    activeMenuItemBackgroundColor: CoreTokens.color_grey_100,
    selectedMenuItemBackgroundColor: CoreTokens.color_purple_100,
    hoverSelectedMenuItemBackgroundColor: CoreTokens.color_purple_200,
    activeSelectedMenuItemBackgroundColor: CoreTokens.color_purple_200,
    selectedMenuItemFontWeight: CoreTokens.type_semibold,
    sectionTitleFontColor: CoreTokens.color_grey_900,
    sectionTitleFontSize: CoreTokens.type_scale_03,
    sectionTitleFontStyle: CoreTokens.type_normal,
    sectionTitleFontWeight: CoreTokens.type_semibold,
    sectionTitleLineHeight: "24px",
    iconColor: CoreTokens.color_grey_900,
    iconSize: "16px",

Opinionated tokens

    accentColor: string;
    baseColor: string;
    fontColor: string;
    iconColor: string;

image

Closes #1975

@GomezIvann GomezIvann changed the title Contextual menu themes Contextual menu tokens May 9, 2024
@GomezIvann GomezIvann marked this pull request as ready for review May 10, 2024 09:37
@Jialecl Jialecl self-requested a review May 13, 2024 06:24
@Jialecl Jialecl self-assigned this May 13, 2024
@GomezIvann GomezIvann requested a review from Jialecl May 14, 2024 07:00
@Jialecl Jialecl merged commit 2c7db3b into master May 15, 2024
@Jialecl Jialecl deleted the gomezivann/contextual-menu-themes branch May 15, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contextual menu's selected option's background color is not themable

3 participants