NavTabs overflow and z-index behaviour improved #1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mil4n0r
reviewed
Mar 22, 2024
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
There should be a cleaner way to perform this task without having to use scrollWidth, but I haven't been able to do it either.
Maybe there is a way to get rid of Underline entirely and just handle it in the Tab border-bottom. However, that would cause the problem stated here #1525 if no other modifications are done.
Mil4n0r
approved these changes
Apr 11, 2024
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
No other working solutions have been found and this pattern was already used in regular Tabs so we will stick to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Overflow was added to the NavTabs and fixed an issue related to z-index.
Description
Overflow was added and the width of the NavTabs is now based on the available space including the scroll in case it is scrollable.
The z-index for the whole component is set to 0 and the underline is set to -1, instead of setting the component tabs to 1.
Screenshots
Closes #1923