Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 6, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Implementing the new StatusLight component, including testing and documentation.

Closes #1803

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 6, 2024

Only the basic documentation for the website was done.
Design part and basic usage are still missing. (It is possible to create a new task for it)

@Mil4n0r Mil4n0r marked this pull request as ready for review February 6, 2024 14:35
@GomezIvann
Copy link
Collaborator

An observation on this PR and for the next time. When we develop a new component we normally do the implementation first and then the documentation in a separate PR. This alleviates the burden of the review, allows the task to be broken down into smaller modules and also has the benefit that once the implementation has been merged, a new version of the library is generated and can therefore be used in the documentation PR for the examples.

@raquelarrojo
Copy link
Collaborator

raquelarrojo commented Feb 7, 2024

Also, developers are only in charge of the Code tab. Usage and Specifications are created by the designers in most of the cases, since they are who best know its usage and specs.

@GomezIvann GomezIvann self-requested a review February 8, 2024 16:21
@GomezIvann GomezIvann self-assigned this Feb 8, 2024
@GomezIvann GomezIvann removed their request for review February 9, 2024 13:03
@GomezIvann GomezIvann removed their assignment Feb 9, 2024
@Jialecl Jialecl self-requested a review February 12, 2024 10:35
@Jialecl Jialecl assigned Jialecl and unassigned Jialecl Feb 12, 2024
@Jialecl Jialecl removed their request for review February 12, 2024 10:57
@Mil4n0r Mil4n0r requested a review from jsuarezgonz February 12, 2024 12:16
@jsuarezgonz jsuarezgonz self-assigned this Feb 12, 2024
@jsuarezgonz jsuarezgonz merged commit 18ade79 into master Feb 12, 2024
@jsuarezgonz jsuarezgonz deleted the Mil4n0r/status_light-component branch February 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Component: Status Light

6 participants