Skip to content

Conversation

@Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jan 29, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Footer and Header were accepting an Object as their margin prop, while it made no sense due to only changing margin-top and margin-bottom respectively.

Additional context
The documentation was already updated to display these types

Closes #1710

@raquelarrojo raquelarrojo self-requested a review January 30, 2024 15:41
@raquelarrojo raquelarrojo self-assigned this Jan 30, 2024
@raquelarrojo raquelarrojo merged commit 757bc34 into master Jan 30, 2024
@raquelarrojo raquelarrojo deleted the Mil4n0r/header_footer_types-fix branch January 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The footer and header margin prop is wrongly typed

3 participants