Remove BackgroundColorProvider from Halstack
#1774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
changed the title
BackgroundColorProvider
GomezIvann
changed the title
BackgroundColorProviderBackgroundColorProvider from Halstack
Jialecl
reviewed
Jan 29, 2024
Collaborator
|
There is a visual test for the container that can be removed, since it is testing the container with a black background. |
Collaborator
|
We still have references to onDark in the color page, the advanced theme example and the advanced theme generator. |
Collaborator
Author
The Color Usage Page is removed in another PR (#1750) and the theme generator needs to be updated in a separate one (it requires a new version of the library with the tokens removed). Otherwise, the app would crush. |
Jialecl
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Our design tokens are currently under review, and our future way of implementing the Dark Theme will likely be very different from the current one. Until we figure out how to properly build a hierarchy of tokens. This functionality is going to be in the shadows.