Skip to content

Updates to Halstack documentation #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 30, 2024
Merged

Updates to Halstack documentation #1750

merged 8 commits into from
Jan 30, 2024

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Dec 26, 2023 •
edited
Loading

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary of the updates in the documentation site:

  • The Box component has been deprecated.
  • The BackgroundColorProvider page in the Color principle has been removed.
  • Fixed Chip stories icon.

@GomezIvann GomezIvann marked this pull request as draft December 26, 2023 13:29
@GomezIvann GomezIvann added the site updates Some updates have been made on the Halstack site. label Dec 26, 2023
@GomezIvann GomezIvann marked this pull request as ready for review January 16, 2024 16:36
@GomezIvann GomezIvann marked this pull request as draft January 16, 2024 16:36
@GomezIvann GomezIvann marked this pull request as ready for review January 22, 2024 11:37
@raquelarrojo raquelarrojo self-requested a review January 25, 2024 07:22
@raquelarrojo raquelarrojo self-assigned this Jan 25, 2024
@GomezIvann GomezIvann removed the major label Jan 25, 2024
raquelarrojo
raquelarrojo requested changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@raquelarrojo raquelarrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since DxcBox is going to be deprecated, and DxcCard and DxcTag use DxcBox inside, should we deprecate also DxcCard and DxcTag? @GomezIvann

@GomezIvann
Copy link
Collaborator Author

GomezIvann commented Jan 26, 2024 •
edited
Loading

Since DxcBox is going to be deprecated, and DxcCard and DxcTag use DxcBox inside, should we deprecate also DxcCard and DxcTag? @GomezIvann

I don't think so. When we remove the box we just have to change their implementation. And luckily, they both are components that are going to be redesigned soon (I hope so). Do you agree?

@raquelarrojo
Copy link
Collaborator

raquelarrojo commented Jan 26, 2024

Since DxcBox is going to be deprecated, and DxcCard and DxcTag use DxcBox inside, should we deprecate also DxcCard and DxcTag? @GomezIvann

I don't think so. When we remove the box we just have to change their implementation. And luckily, they both are components that are going to be redesigned soon (I hope so). Do you agree?

Totally agree. They will be redesigned and reimplemented soon 🤞🏻.

@GomezIvann GomezIvann mentioned this pull request Jan 29, 2024
Merged
5 tasks
@raquelarrojo raquelarrojo merged commit bd89f9e into master Jan 30, 2024
@raquelarrojo raquelarrojo deleted the gomezivann/website-updates branch January 30, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raquelarrojo raquelarrojo raquelarrojo approved these changes

Assignees

@raquelarrojo raquelarrojo

Labels

site updates Some updates have been made on the Halstack site.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GomezIvann @raquelarrojo