Skip to content

Adding title prop to Button #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Adding title prop to Button #1647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06686aa
New Button title prop
GomezIvann Jul 7, 2023
4c1a9f5
Updates to the Button documentation
GomezIvann Jul 7, 2023
dcaccf0
Merge branch 'master' into gomezivann-button-title
Jialecl Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/button/Button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const Chromatic = () => (
<Title title="Only icon (image)" theme="light" level={4} />
<DxcButton
mode="text"
icon="https://developer.apple.com/design/human-interface-guidelines/foundations/app-icons/images/icon-and-image-large-icon-settings_2x.png"
icon="https://www.freepnglogos.com/uploads/facebook-logo-design-1.png"
/>
</ExampleContainer>
<BackgroundColorProvider color="#333333">
Expand Down
10 changes: 9 additions & 1 deletion lib/src/button/Button.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from "react";
import { render, fireEvent } from "@testing-library/react";
import { render, fireEvent, getByRole } from "@testing-library/react";
import DxcButton from "./Button.tsx";

describe("Button component tests", () => {
Expand All @@ -16,4 +16,12 @@ describe("Button component tests", () => {
fireEvent.click(button);
expect(onClick).toHaveBeenCalled();
});

test("Renders with correct accessibility attributes", () => {
const { getByRole } = render(<DxcButton label="Home" title="Go home" />);

const button = getByRole("button");
expect(button.getAttribute("aria-label")).toBe("Go home");
expect(button.getAttribute("title")).toBe("Go home");
});
});
Loading