Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jun 19, 2023

Checklist

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Closes #1624

@GomezIvann GomezIvann changed the title Remove deprecated padding prop from Box component Remove deprecated padding prop from the Box component Jun 19, 2023
@GomezIvann GomezIvann marked this pull request as ready for review June 19, 2023 15:27
@raquelarrojo raquelarrojo self-requested a review June 20, 2023 07:26
@raquelarrojo raquelarrojo self-assigned this Jun 20, 2023
Copy link
Collaborator

@raquelarrojo raquelarrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change this sentence related to the padding in Usage.
image

@GomezIvann GomezIvann requested a review from raquelarrojo June 21, 2023 11:12
@raquelarrojo raquelarrojo merged commit da4b2be into master Jun 21, 2023
@raquelarrojo raquelarrojo deleted the gomezivann-box-padding branch June 21, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated padding prop from Box

3 participants