Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented May 15, 2023

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Update sidenav styling to make the different states of a sidenav item (collapsable groups and links) more visual, intuitive and consistent.

Description
Summary of changes:

  • Token values updated. Specs and affected files have also been updated.
  • Reimplementation of the last use of the legacy API React.Children. This required a change in the functionality of the Sidenav regarding the sections of the component, which now are separated between dividers only when using DxcSidenav.Section.

@GomezIvann GomezIvann changed the title Gomezivann/sidenav updates Sidenav styles review May 15, 2023
@GomezIvann GomezIvann marked this pull request as ready for review May 16, 2023 08:39
@aidamag aidamag self-assigned this May 19, 2023
@Jialecl Jialecl self-requested a review May 19, 2023 08:28
@Jialecl Jialecl self-assigned this May 19, 2023
@Jialecl Jialecl merged commit c83579c into master May 29, 2023
@Jialecl Jialecl deleted the gomezivann/sidenav-updates branch May 29, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants