Skip to content

Conversation

@raquelarrojo
Copy link
Collaborator

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Nav tabs previews are left in theme generator, so its opinionated theme cannot be changed.

Description
Nav tabs previews added to theme generator.

Screenshots
image

Closes #1502

@raquelarrojo raquelarrojo marked this pull request as ready for review March 1, 2023 11:52
@Jialecl Jialecl self-requested a review March 1, 2023 13:01
@Jialecl Jialecl self-assigned this Mar 1, 2023
@Jialecl
Copy link
Collaborator

Jialecl commented Mar 1, 2023

The token unselectedBackgroundColor is not been used.

image

@raquelarrojo
Copy link
Collaborator Author

The token unselectedBackgroundColor is not been used.

image

Fixed! @Jialecl

image

Fix will not be visible in theme generator until cdk version is updated in website.

@Jialecl Jialecl merged commit ad31801 into master Mar 1, 2023
@Jialecl Jialecl deleted the rarrojolopez-navtabs-themeGenerator branch March 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nav tabs previews are missing in theme generator

3 participants