Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jan 27, 2023

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • Update the specifications page of the Select component to match the new options icon sizing.
  • Minor code refactors:
    • Now the component uses the Resize Observer API for the width of the Listbox.
    • ThemeProvider is only used in the parent component (Select.tsx). Sub-components don't have it anymore to avoid additional renders.
    • Adjustments based on the above changes.

@GomezIvann GomezIvann marked this pull request as ready for review January 27, 2023 13:24
@jsuarezgonz jsuarezgonz self-requested a review February 1, 2023 13:46
@jsuarezgonz jsuarezgonz self-assigned this Feb 2, 2023
@jsuarezgonz jsuarezgonz merged commit a062293 into master Feb 2, 2023
@jsuarezgonz jsuarezgonz deleted the gomezivann-select-updates branch February 2, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants