Skip to content

File Input button size, stories update and small code refactors #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2022
Merged

File Input button size, stories update and small code refactors #1372

merged 2 commits into from
Nov 10, 2022

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Nov 8, 2022 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  • Change File Input's button size to fitContent in file mode.
  • Updated stories of the File Input component to try to solve chromatic snapshot testing issues regarding each file item's delete button states.
  • Minor code refactors and styling improvements.
  • Include localization for Delete file action aria-label and title.

Closes #1082 and #760

@GomezIvann GomezIvann changed the title Fix File Input button size, stories updated & small code refactors File Input button size, stories update & small code refactors Nov 8, 2022
@GomezIvann GomezIvann changed the title File Input button size, stories update & small code refactors File Input button size, stories update and small code refactors Nov 8, 2022
@GomezIvann GomezIvann linked an issue Nov 10, 2022 that may be closed by this pull request
[Chromatic] File input hover, focus and active tests are not working fine #760
Closed
@GomezIvann GomezIvann marked this pull request as ready for review November 10, 2022 11:35
@raquelarrojo raquelarrojo self-requested a review November 10, 2022 11:46
@raquelarrojo raquelarrojo self-assigned this Nov 10, 2022
@raquelarrojo raquelarrojo merged commit c18d61a into master Nov 10, 2022
@raquelarrojo raquelarrojo deleted the gomezivann-fileInput-fix branch November 10, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raquelarrojo raquelarrojo raquelarrojo approved these changes

Assignees

@raquelarrojo raquelarrojo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[File-Input] Button size is not fitting the custom label [Chromatic] File input hover, focus and active tests are not working fine

3 participants

@GomezIvann @raquelarrojo