Skip to content

Fixed text input's action that executed form submit when clicked #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fixed text input's action that executed form submit when clicked #1365

merged 2 commits into from
Nov 3, 2022

Conversation

@aidamag
Copy link
Contributor

@aidamag aidamag commented Nov 3, 2022

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
As @GomezIvann said, adding type="button" in the actions solved the problem.
Added test.

Closes #1363

@aidamag aidamag marked this pull request as ready for review November 3, 2022 11:03
@GomezIvann GomezIvann self-requested a review November 3, 2022 11:08
@GomezIvann GomezIvann self-assigned this Nov 3, 2022
@GomezIvann GomezIvann merged commit 3a65d35 into master Nov 3, 2022
@GomezIvann GomezIvann deleted the aida-form-input branch November 3, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GomezIvann GomezIvann GomezIvann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GomezIvann GomezIvann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Text Input's action executes form submit when it is clicked.

3 participants

@aidamag @GomezIvann