Skip to content

Refactoring the html code of the quick nav #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

Refactoring the html code of the quick nav #1334

merged 2 commits into from
Oct 17, 2022

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 11, 2022 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Restructuring the DOM tree of the Quick Nav component, to match the HTML Standards and accessibility requirements.

Screenshots
Accessibility concerns related to the Quick Nav no longer appear.

image

Closes #1316

@GomezIvann GomezIvann marked this pull request as ready for review October 13, 2022 08:51
@Jialecl Jialecl self-requested a review October 17, 2022 09:09
@Jialecl Jialecl merged commit 0ea575c into master Oct 17, 2022
@Jialecl Jialecl deleted the gomezivann-quicknav-fix branch October 17, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessibility concerns with Quick Nav component

3 participants

@GomezIvann @Jialecl